Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Support for PHP 8.4 #96

Merged
merged 4 commits into from
Nov 17, 2024
Merged

Add Support for PHP 8.4 #96

merged 4 commits into from
Nov 17, 2024

Conversation

fezfez
Copy link
Contributor

@fezfez fezfez commented Nov 15, 2024

  • Allow php 8.4
  • composer bump --dev-only
  • phpunit/phpunit:^10
  • laminas/laminas-coding-standard:^3

amphp/amp has been added to composer.json because of the php 8.4 lowest job, it only work with ^2.6.4

…nas/laminas-coding-standard:^3

Signed-off-by: fezfez <[email protected]>
Signed-off-by: fezfez <[email protected]>

Allow php 8.4 + composer bump --dev-only + phpunit/phpunit:^10 + laminas/laminas-coding-standard:^3

Signed-off-by: fezfez <[email protected]>
composer.json Outdated Show resolved Hide resolved
psalm.xml Show resolved Hide resolved
src/SessionManager.php Show resolved Hide resolved
test/Config/SessionConfigTest.php Show resolved Hide resolved
test/SaveHandler/AbstractDbTableGateway.php Outdated Show resolved Hide resolved
test/SaveHandler/DbTableGateway/MysqliAdapter.php Outdated Show resolved Hide resolved
test/SaveHandler/DbTableGateway/PdoMysqlAdapter.php Outdated Show resolved Hide resolved
test/SaveHandler/DbTableGateway/PdoSqliteAdapter.php Outdated Show resolved Hide resolved
test/SaveHandler/DbTableGateway/PgsqlAdapter.php Outdated Show resolved Hide resolved
Signed-off-by: fezfez <[email protected]>
Signed-off-by: fezfez <[email protected]>
@fezfez
Copy link
Contributor Author

fezfez commented Nov 16, 2024

@gsteel ready for another review 👍

Copy link
Member

@gsteel gsteel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍 Thanks @fezfez LGTM!

@gsteel gsteel self-assigned this Nov 17, 2024
@gsteel gsteel added this to the 2.22.0 milestone Nov 17, 2024
@gsteel gsteel merged commit 97639e1 into laminas:2.22.x Nov 17, 2024
17 checks passed
@gsteel gsteel changed the title Allow php 8.4 Add Support for PHP 8.4 Nov 17, 2024
@gsteel gsteel mentioned this pull request Nov 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

3 participants